forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-11042] [SQL] Add a mechanism to ban creating multiple root SQL…
…Contexts/HiveContexts in a JVM https://issues.apache.org/jira/browse/SPARK-11042 Author: Yin Huai <yhuai@databricks.com> Closes apache#9058 from yhuai/SPARK-11042.
- Loading branch information
Showing
4 changed files
with
156 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
sql/core/src/test/scala/org/apache/spark/sql/MultiSQLContextsSuite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql | ||
|
|
||
| import org.apache.spark._ | ||
| import org.scalatest.BeforeAndAfterAll | ||
|
|
||
| class MultiSQLContextsSuite extends SparkFunSuite with BeforeAndAfterAll { | ||
|
|
||
| private var originalActiveSQLContext: Option[SQLContext] = _ | ||
| private var originalInstantiatedSQLContext: Option[SQLContext] = _ | ||
| private var sparkConf: SparkConf = _ | ||
|
|
||
| override protected def beforeAll(): Unit = { | ||
| originalActiveSQLContext = SQLContext.getActiveContextOption() | ||
| originalInstantiatedSQLContext = SQLContext.getInstantiatedContextOption() | ||
|
|
||
| SQLContext.clearActive() | ||
| originalInstantiatedSQLContext.foreach(ctx => SQLContext.clearInstantiatedContext(ctx)) | ||
| sparkConf = | ||
| new SparkConf(false) | ||
| .setMaster("local[*]") | ||
| .setAppName("test") | ||
| .set("spark.ui.enabled", "false") | ||
| .set("spark.driver.allowMultipleContexts", "true") | ||
| } | ||
|
|
||
| override protected def afterAll(): Unit = { | ||
| // Set these states back. | ||
| originalActiveSQLContext.foreach(ctx => SQLContext.setActive(ctx)) | ||
| originalInstantiatedSQLContext.foreach(ctx => SQLContext.setInstantiatedContext(ctx)) | ||
| } | ||
|
|
||
| def testNewSession(rootSQLContext: SQLContext): Unit = { | ||
| // Make sure we can successfully create new Session. | ||
| rootSQLContext.newSession() | ||
|
|
||
| // Reset the state. It is always safe to clear the active context. | ||
| SQLContext.clearActive() | ||
| } | ||
|
|
||
| def testCreatingNewSQLContext(allowsMultipleContexts: Boolean): Unit = { | ||
| val conf = | ||
| sparkConf | ||
| .clone | ||
| .set(SQLConf.ALLOW_MULTIPLE_CONTEXTS.key, allowsMultipleContexts.toString) | ||
| val sparkContext = new SparkContext(conf) | ||
|
|
||
| try { | ||
| if (allowsMultipleContexts) { | ||
| new SQLContext(sparkContext) | ||
| SQLContext.clearActive() | ||
| } else { | ||
| // If allowsMultipleContexts is false, make sure we can get the error. | ||
| val message = intercept[SparkException] { | ||
| new SQLContext(sparkContext) | ||
| }.getMessage | ||
| assert(message.contains("Only one SQLContext/HiveContext may be running")) | ||
| } | ||
| } finally { | ||
| sparkContext.stop() | ||
| } | ||
| } | ||
|
|
||
| test("test the flag to disallow creating multiple root SQLContext") { | ||
| Seq(false, true).foreach { allowMultipleSQLContexts => | ||
| val conf = | ||
| sparkConf | ||
| .clone | ||
| .set(SQLConf.ALLOW_MULTIPLE_CONTEXTS.key, allowMultipleSQLContexts.toString) | ||
| val sc = new SparkContext(conf) | ||
| try { | ||
| val rootSQLContext = new SQLContext(sc) | ||
| testNewSession(rootSQLContext) | ||
| testNewSession(rootSQLContext) | ||
| testCreatingNewSQLContext(allowMultipleSQLContexts) | ||
|
|
||
| SQLContext.clearInstantiatedContext(rootSQLContext) | ||
| } finally { | ||
| sc.stop() | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters