Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postprocessor): integrate OwlBot locally and add basic post-processor to copy generated code into libraries #1

Merged
merged 9 commits into from
Oct 26, 2022

Conversation

adrianajg
Copy link
Owner

Create .github/.OwlBot.yaml and .github/.OwlBot.lock.yaml files

  • Invoking OwlBot locally copies generated code into specified destination directory: owl-bot-staging/

Create basic post-processor

  • Invoking post-processor locally copies code from owl-bot-staging/ into respective libraries and performs go mod tidy and gofmt -sdwl . on each directory

@adrianajg adrianajg marked this pull request as ready for review October 19, 2022 16:40
.github/.OwlBot.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks just, just a handful of small cleanup stuff.

.github/.OwlBot.lock.yaml Outdated Show resolved Hide resolved
internal/postprocessor/Dockerfile Show resolved Hide resolved
internal/postprocessor/go.mod Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more small things

internal/postprocessor/Dockerfile Outdated Show resolved Hide resolved
internal/postprocessor/execv/command.go Outdated Show resolved Hide resolved
internal/postprocessor/execv/gocmd/gocmd.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Outdated Show resolved Hide resolved
internal/postprocessor/main.go Show resolved Hide resolved
@@ -0,0 +1,4 @@
docker:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you still have these files checked in. An easy way to fix is comment out line in gitignore, delete them temp, uncomment gitignore, readded them for yourself locally.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell -- does it look like I fixed it?

Copy link
Collaborator

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@adrianajg adrianajg merged commit f9762d0 into Postprocessor Oct 26, 2022
@adrianajg adrianajg deleted the OwlBot branch October 26, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants