-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(postprocessor): integrate OwlBot locally and add basic post-processor to copy generated code into libraries #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks just, just a handful of small cleanup stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more small things
.github/.OwlBot.lock.yaml
Outdated
@@ -0,0 +1,4 @@ | |||
docker: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you still have these files checked in. An easy way to fix is comment out line in gitignore, delete them temp, uncomment gitignore, readded them for yourself locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell -- does it look like I fixed it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Create
.github/.OwlBot.yaml
and.github/.OwlBot.lock.yaml
filesowl-bot-staging/
Create basic post-processor
owl-bot-staging/
into respective libraries and performsgo mod tidy
andgofmt -sdwl .
on each directory