New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(postprocessor): rewrite OwlBot PR title and body commits to include scope #6

Merged

adrianajg merged 23 commits into Postprocessor from CommitMessages

Dec 19, 2022

Owner

adrianajg commented Dec 7, 2022

Access open PR request
Use OwlBot api-name feature in .OwlBot.yaml to set all square-bracketed scopes inserted by OwlBot to [REPLACEME]
Find all [REPLACEME] substrings in PR title and body, use corresponding Source-Link URLs of googleapis/googleapis/ commits to extract commit hash, then find scope by analyzing files changed in that commit

Note: Does not yet update open PR as container lacks necessary credentials

adrianajg added 19 commits

November 23, 2022 14:21


          write collectPRBody function

a86395a


          TESTING

6593e16


          amendPRDescription finds open PR, title, and body

8a3d5ba


          removed access token

431a4be


          getChangedPackageNames function identifies modules changed in commit

c365dc7


          getScopeFromGoogleapisCommitHash returns a slice of scopes, as of yet…

fc5de2b

… untested with multiple files changed in a single commit


          Scope(s) found using commit hash by iterating through generator.Micro…

aa45c2d

…genGapicConfigs to find correct package name


          PR title text is amended with scope, (not pushed back to PR)

e15b8c5


          cleaned up

56bfd9f


          added test and PR title is updated to include scope

c7d3e25


          main_test pass for title update

34affe7


          main_test.go passing


          scope outside of gapicgen/generator/config.go returns title with no s…

9ae3139

…cope


          regex expression for extracting parts of commit title, add owl-bot-st…

740c9e5

…aging to .gitignore


          clean up in progress

8e59b26


          in progress

0a74f7c


          clean up

cb2af9a


          Test run on accessapproval with full postprocessor script worked

7cdc324


          reset branchPrefix flag to default of 'owl-bot-copy-'

ee53795

adrianajg requested a review from codyoss

December 7, 2022 22:30

adrianajg marked this pull request as ready for review

December 7, 2022 22:30

codyoss reviewed

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

codyoss reviewed

View reviewed changes

internal/postprocessor/go.mod Outdated Show resolved Hide resolved

codyoss requested changes

View reviewed changes

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

adrianajg force-pushed the CommitMessages branch from 0eb667e to f0b74df Compare

December 13, 2022 16:13


          restructure and resolve review issues

37caa90

adrianajg force-pushed the CommitMessages branch from f0b74df to 37caa90 Compare

December 13, 2022 17:32

adrianajg commented

View reviewed changes

Owner Author

adrianajg left a comment

Addressed changes and did some refactoring. Ready for additional feedback!

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/go.mod Outdated Show resolved Hide resolved

.gitignore Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

codyoss reviewed

View reviewed changes

Collaborator

codyoss left a comment

Did a deeper review this time so this should be the last one. Thanks for the changes :)

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main_test.go Show resolved Hide resolved


          Resolve changes 2

c713d11

adrianajg commented

View reviewed changes

Owner Author

adrianajg left a comment

A couple of loose ends still, let me know your thoughts please. Thanks!

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main_test.go Show resolved Hide resolved

codyoss reviewed

View reviewed changes

internal/postprocessor/main.go Outdated Show resolved Hide resolved

Collaborator

codyoss commented Dec 19, 2022

@adrianajg It looks like you still have some failing vet tests. I think most(maybe all), would be fixed if you have format on save on.

codyoss approved these changes

View reviewed changes

adrianajg added 2 commits

December 19, 2022 13:30


          addressing further requested changes

059d10b


          trying to pass vet check

f85d4fd

adrianajg merged commit 986587e into Postprocessor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet