Add isNaN(str) check

adrianchia · Jul 22, 2014 · 5c1c8cc · 5c1c8cc
1 parent 5582300
commit 5c1c8cc
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/1-echo/package.json b/1-echo/package.json
@@ -13,7 +13,7 @@
   },
   "main": "server.js",
   "scripts": {
-    "test": "node server.js && mocha",
+    "test": "mocha",
     "start": "node server.js"
   },
   "dependencies": {

diff --git a/2-video/package.json b/2-video/package.json
@@ -13,7 +13,7 @@
   },
   "main": "server.js",
   "scripts": {
-    "test": "node server.js && mocha",
+    "test": "mocha",
     "start": "node server.js"
   },
   "dependencies": {

diff --git a/2-video/server.js b/2-video/server.js
@@ -21,11 +21,12 @@ app.get('/video', function(req,res) {
 });
 
 app.post('/video', function(req, res) {
+	console.log(req.body);
 	var name = req.body.name;
 	var url = req.body.url;
 	var duration = req.body.duration;
 
-	if(!name || !url || !duration || name.length < 1 || url.length < 10 || parseInt(duration) < 0) {
+	if(!name || !url || !duration || name.length < 1 || url.length < 10 || isNaN(duration) || parseInt(duration) < 0) {
 		res
 			.status(400)
 			.send("Missing ['name','duration','url'].");

diff --git a/2-video/test/server.test.js b/2-video/test/server.test.js
@@ -39,5 +39,23 @@ describe('Video test add and list', function() {
 			.expect(400)
 			.expect("Missing ['name','duration','url'].", done);
 	});
+
+	it("should return Missing ['name','duration','url'].", function(done) {
+		request(BASE_URL)
+			.post('/video')
+			.set('Content-Type','application/x-www-form-urlencoded')
+			.send({"name": '', "url": 'www.a.com', "duration": ""})
+			.expect(400)
+			.expect("Missing ['name','duration','url'].", done);
+	});
+
+	it("should return Missing ['name','duration','url'].", function(done) {
+		request(BASE_URL)
+			.post('/video')
+			.set('Content-Type','application/x-www-form-urlencoded')
+			.send({"name": '', "url": 'www.a.com', "duration": "aaa"})
+			.expect(400)
+			.expect("Missing ['name','duration','url'].", done);
+	});
 });