Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add default losses to KerasClassifier and KerasRegressor #208

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

ENH: Add default losses to KerasClassifier and KerasRegressor #208

wants to merge 52 commits into from

Commits on Feb 27, 2021

  1. Add default loss to KerasClassifier

    @stsievert
    stsievert committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    4be5d0c View commit details
    Browse the repository at this point in the history

  2. update message/tests

    @stsievert
    stsievert committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    dccd92b View commit details
    Browse the repository at this point in the history

  3. black

    @stsievert
    stsievert committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    1d80b57 View commit details
    Browse the repository at this point in the history

  4. isort

    @stsievert
    stsievert committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    1f45285 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2021

  1. better test

    @stsievert
    stsievert committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    9358d6e View commit details
    Browse the repository at this point in the history

  2. Add default loss for KerasRegressor

    @stsievert
    stsievert committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    6cc112e View commit details
    Browse the repository at this point in the history

  3. black

    @stsievert
    stsievert committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    80618bf View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. catch binary cross entropy

    @stsievert
    stsievert committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    60b2404 View commit details
    Browse the repository at this point in the history

  2. black

    @stsievert
    stsievert committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    dcb0823 View commit details
    Browse the repository at this point in the history

  3. Clean type hints in __init__

    @stsievert
    stsievert committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    0faadd9 View commit details
    Browse the repository at this point in the history

  4. isort

    @stsievert
    stsievert committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    0449481 View commit details
    Browse the repository at this point in the history

  5. change KerasRegressor.__init__

    @stsievert
    stsievert committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    ed4c1f5 View commit details
    Browse the repository at this point in the history

  6. tests run

    @stsievert
    stsievert committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    c58ec74 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. MAINT

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    e73710d View commit details
    Browse the repository at this point in the history

  2. add right loss back

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    4e7e09f View commit details
    Browse the repository at this point in the history

  3. Try removing binary_crossentropy check

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    2e830ff View commit details
    Browse the repository at this point in the history

  4. black

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    e1ea339 View commit details
    Browse the repository at this point in the history

  5. remove annoying 'needs linting'

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    36e6499 View commit details
    Browse the repository at this point in the history

  6. Uncomment error

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    8310834 View commit details
    Browse the repository at this point in the history

  7. warn for user compiled models

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    6ee8b50 View commit details
    Browse the repository at this point in the history

  8. Union[T, None] → Optional[T]

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    b88b74e View commit details
    Browse the repository at this point in the history

  9. DOC: complete docstring

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    3a3a536 View commit details
    Browse the repository at this point in the history

  10. DOC: complete docstring

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    9808cf2 View commit details
    Browse the repository at this point in the history

  11. fix loss?

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    d0147ac View commit details
    Browse the repository at this point in the history

  12. Revert "fix loss?" 

    This reverts commit d0147ac.
    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    7243995 View commit details
    Browse the repository at this point in the history

  13. Warn if compiled with wrong loss 

    If user compiles the model themselves, they know what they're doing
    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    9735974 View commit details
    Browse the repository at this point in the history

  14. draft at loss=None

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    8cc0474 View commit details
    Browse the repository at this point in the history

  15. v2

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    b0229c5 View commit details
    Browse the repository at this point in the history

  16. black

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    dccfc5e View commit details
    Browse the repository at this point in the history

  17. Tell mypy to use type hints

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    d2e23cb View commit details
    Browse the repository at this point in the history

  18. loss=None to docs

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    9c3af6b View commit details
    Browse the repository at this point in the history

  19. whoops on type hints

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    5121131 View commit details
    Browse the repository at this point in the history

  20. Update tests/test_simple_usage.py 

    Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
    @stsievert @adriangb
    stsievert and adriangb authored Mar 2, 2021
    Configuration menu
    Copy the full SHA
    0dfa526 View commit details
    Browse the repository at this point in the history

  21. Update scikeras/wrappers.py 

    Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
    @stsievert @adriangb
    stsievert and adriangb authored Mar 2, 2021
    Configuration menu
    Copy the full SHA
    7b379d7 View commit details
    Browse the repository at this point in the history

  22. Update tests/test_simple_usage.py 

    Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
    @stsievert @adriangb
    stsievert and adriangb authored Mar 2, 2021
    Configuration menu
    Copy the full SHA
    e4338fc View commit details
    Browse the repository at this point in the history

  23. Add classifier default loss test

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    ca69f2e View commit details
    Browse the repository at this point in the history

  24. Merge branch 'clf-default-loss' of https://github.com/stsievert/scikeras 

     into clf-default-loss
    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    2ac57e0 View commit details
    Browse the repository at this point in the history

  25. Better warning for (really rare) use case

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    0de8abe View commit details
    Browse the repository at this point in the history

  26. update warning with more recommendations

    @stsievert
    stsievert committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    0cf7610 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. TST: all classification losses 

    ...in user compiled model with N_CLASSES outputs
    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    d4c3eea View commit details
    Browse the repository at this point in the history

  2. Re-initialize

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    7fab517 View commit details
    Browse the repository at this point in the history

  3. tmp

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    59e7012 View commit details
    Browse the repository at this point in the history

  4. loss_name is None

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    0386e4e View commit details
    Browse the repository at this point in the history

  5. black

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    3a46538 View commit details
    Browse the repository at this point in the history

  6. Remove backticks

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    8f2b00b View commit details
    Browse the repository at this point in the history

  7. typing for utils/*_name

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    e80338b View commit details
    Browse the repository at this point in the history

  8. raise

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    7e23480 View commit details
    Browse the repository at this point in the history

  9. API: loss_name / metric_name return None

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    94df48a View commit details
    Browse the repository at this point in the history

  10. try cce

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    35e1a6c View commit details
    Browse the repository at this point in the history

  11. catch loss is not None

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    f092b7a View commit details
    Browse the repository at this point in the history

  12. tmp

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    5af8b4c View commit details
    Browse the repository at this point in the history

  13. typo

    @stsievert
    stsievert committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    7b38bc8 View commit details
    Browse the repository at this point in the history