Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StringPrivateKeySource #3

Merged
merged 2 commits into from
Aug 11, 2018
Merged

Add StringPrivateKeySource #3

merged 2 commits into from
Aug 11, 2018

Conversation

derwasp
Copy link
Contributor

@derwasp derwasp commented Aug 2, 2018 •
edited
Loading

Proposed changes:

  • Add StringPrivateKeySource

@adriangodong
Copy link
Owner

Thank you for your contribution.

Code looks good, please add a unit test to verify.

@adriangodong adriangodong merged commit 7b727ec into adriangodong:master Aug 11, 2018
@adriangodong adriangodong mentioned this pull request Aug 11, 2018
Merged
@derwasp
Copy link
Contributor Author

derwasp commented Aug 22, 2018

sorry, got lost in some other stuff. I can see that you did it already, thanks.

@derwasp derwasp deleted the feature/string-private-key-source branch August 22, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derwasp @adriangodong