Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Garmin sensor status information #117

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

tnn2
Copy link
Contributor

@tnn2 tnn2 commented Aug 9, 2024

Hi, I have a Garmin GPS, model 24xd HVS, NMEA 0183.
Every minute I get this error notice in the log of my program.
2024/08/09 11:27:00 Error parsing NMEA sentence: nmea: sentence prefix 'PGRMT' not supported

I implemented support for the PGRMT sentence in order to get rid of the log message.

@aldas
Copy link
Collaborator

aldas commented Aug 9, 2024

You can ignore these errors like that

		sentence, err := nmea.Parse(raw)
		var errNotSupported *nmea.NotSupportedError
		if errors.Is(err, errNotSupported) {
			s.logger.Debug().Err(err).Str("raw", raw).Msg("unsupported NMEA0183 message")
			continue
		}

p.s. please fix linter problems. You can check those locally with make check

icholy
icholy previously approved these changes Aug 12, 2024
pgrmt_test.go Outdated Show resolved Hide resolved
@icholy icholy merged commit cd0f55b into adrianmo:master Aug 12, 2024
4 checks passed
@icholy
Copy link
Collaborator

icholy commented Aug 12, 2024

@tnn2 thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants