Add sentences: HDG, HDM, MTW, ROT, TXT, PHTRO, PRDID, PSONCMS. + more #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I think MTK implementation is not correct. MTK is command protocol embedded into NMEA sentence. Fields that current MTK struct has are meant for MTK packet "PMTK001" but actually MTK packet can have variable amound of data fields.
See:
Note 2: I think
p.EnumString(4, "variation direction", East, West),
implementation maybe needs counterpart that sets error when value is empty""
currently it does not error. Sometimes is OK when field is empty but times it is not.Note 3: in newer sentences testcase tables are inside test methods. This is because in that way Goland allows you to execute each testcase separately if you want - which is handy. VsCode does not have that feature yet but there are open feature tickets so it will probably land in there also.