fix record PrintMembers() handling of positional properties of refere…

…nce types

Only positional properties typed as string, primitive types or type parameters were being handled.
Positional properties of all other reference types would simply be ignored in by PrintMembers()

Cecilifier.Core.Tests/Tests/OutputBased/RecordTests.cs

@@ -83,6 +83,19 @@ public void RecordPropertyAccess()
  record Record(int Value);
  """,
  "42");
+ } 
+
+ [Test]
+ public void CyclicReferences()
+ {
+ AssertOutput(
+ """
+ var ri = new Record("Child", new Record("Parent", null));
+ System.Console.WriteLine($"{ri.Name},{ri.Other.Equals(ri.Other)},{ri}"); 
+
+ record Record(string Name, Record Other);
+ """,
+ "Child,True,Record { Name = Child, Other = Record { Name = Parent, Other = } }");
  }
  }
 

Cecilifier.Core/CodeGeneration/Record.Generator.cs

@@ -569,14 +569,23 @@ string PrintMembersMethodToCall()
 
  static IMethodSymbol StringBuilderAppendMethodFor(IVisitorContext context, ITypeSymbol type, ITypeSymbol stringBuilderSymbol)
  {
- // if type is a generic type parameter we should use the `object` overload instead and box.
- var targetType = type.TypeKind == TypeKind.TypeParameter ? context.RoslynTypeSystem.SystemObject : type;
- var stringBuilderAppendMethod = stringBuilderSymbol
- .GetMembers("Append")
- .OfType<IMethodSymbol>()
- .SingleOrDefault(m => m.Parameters.Length == 1 && SymbolEqualityComparer.Default.Equals(m.Parameters[0].Type, targetType));
+ var stringBuilderAppendMethod = AppendMethodFor(stringBuilderSymbol, type);
+ if (stringBuilderAppendMethod != null)
+ return stringBuilderAppendMethod;
+
+ // if type is a generic type parameter or a class use the `object` overload instead.
+ return type.TypeKind == TypeKind.TypeParameter || !type.IsValueType 
+ ? AppendMethodFor(stringBuilderSymbol, context.RoslynTypeSystem.SystemObject) 
+ :null;
 
- return stringBuilderAppendMethod;
+ static IMethodSymbol AppendMethodFor(ITypeSymbol typeSymbol, ITypeSymbol type)
+ {
+ var stringBuilderAppendMethod = typeSymbol
+ .GetMembers("Append")
+ .OfType<IMethodSymbol>()
+ .SingleOrDefault(m => m.Parameters.Length == 1 && SymbolEqualityComparer.Default.Equals(m.Parameters[0].Type, type));
+ return stringBuilderAppendMethod;
+ }
  }
  }