Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Kotlinx immutable collections #13

Closed

Conversation

phucynwa
Copy link
Contributor

Because Map<*> is a mutable type, it is unstable and badly affects compose performance, we should use Kotlin immutable collections' ImmutableMap instead.

Refer: https://betterprogramming.pub/optimizing-recomposition-in-jetpack-compose-stability-system-f8ec0c92de33

Signed-off-by: Lê Hồng Phúc <lehongphuc@The-Little-Prince.local>
@sleeyax
Copy link

sleeyax commented Jun 16, 2023

Is this ever gonna get merged?

@hichamboushaba
Copy link

Instead of adding an addition dependency here, why not just mark the Lyricist object as Immutable? IMO it should be enough, and would avoid adding an additional dependency (that's still in alpha) to the library.

@adrielcafe
Copy link
Owner

I agree that @Immutable should be enough and made this change on 1.5.0. If for any reason it don't fix the recomposition/performance issue we can try the immutable collection approach.

Thank you everyone!

@adrielcafe adrielcafe closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants