Add wasmJS support | Update Kotlin and Compose #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #39. |
DevNatan
added
enhancement
|
Awesome! |
|
About the multiplatform sample, yes, this DSL was removed, but no worries, I will bake a Xcodegen file. |
DevSrSouza
approved these changes
Mar 25, 2024
|
No regressions on the iOS side. Screen.Recording.2024-03-24.at.22.03.42.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds wasmJS support, along with updating dependencies (mainly Kotlin -> 1.9.20 and Compose -> 1.6.1).
Also adds a wasmJS source to
sample-multiplatform, and replaces removedWindowwith the newCanvasBasedWindowin the JS sample.This has been tested on wasmJS (along with JS and JVM) and it works without issues.
Note: The iOS
uikitconfiguration block insample-multiplatformhas been probably deprecated (removed) in 1.9.20? I can't find much info aside from this message by Dima Adeev on Slack.I'm not sure how that affects the iOS sample as I don't have a Mac, but I just out-commented that code for now.
Note 2: There are a few warnings regarding not using the new default hierarchy template introduced in Kotlin 1.9.20 (e.g.
iOS()function is deprecated), but I'm not sure how to go about these (nor can I test any changes on the iOS side), so I left them as they are.