Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(default.yaml): disable empty-values & octal-values by default #205

Merged

Conversation

myii
Copy link
Contributor

@myii myii commented Oct 10, 2019


@adrienverge This is the crux of the resolution. What do you think about adding a note in the documentation, under each section (empty-values & octal-values)? It could be used for the time being until existing users become informed that these values were in fact, not enabled.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 97.822% when pulling 01aed2a on myii:fix/disable-empty-and-octal-values into 579a975 on adrienverge:master.

Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myii the PR looks good, thanks!

What do you think about adding a note

I'll answer this in your original issue #204.

@adrienverge adrienverge merged commit 7359785 into adrienverge:master Oct 15, 2019
@myii myii deleted the fix/disable-empty-and-octal-values branch October 15, 2019 12:56
@myii
Copy link
Contributor Author

myii commented Oct 15, 2019

You're welcome, thanks for the idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Default setting (enable) of empty-values & octal-values does nothing
3 participants