-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: make possible to run tests and related stuff using tox #313
Conversation
Make possible to run tests (python setup.py test) and other related stuff (flake8, doc8 and yamllint) using tox. Signed-off-by: Satoru SATOH <satoru.satoh@gmail.com>
I think that it doesn't break anything and just makes our hacking life easier by adding a feature to allow us testing it using just 'tox -e py36' command for example. So could you please take just a little time to looks this? I'm very happy if it's merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand it would save time for people that use tox, but not for others, and I try to keep the repo as simple as possible (for many reasons, including easy maintenance and easy bootstrapping for non-Python users).
I'm not favorable to this, sorry.
I understand you want to keep it simple, however, let me try to explain why it's valuable and necessary for developers from my point of view, please.
|
I opened another PR for this. |
Make possible to run tests (python setup.py test) and other related
stuff (flake8, doc8 and yamllint) using tox.
Signed-off-by: Satoru SATOH satoru.satoh@gmail.com