Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: make possible to run tests and related stuff using tox #313

Closed
wants to merge 1 commit into from

Conversation

ssato
Copy link
Contributor

@ssato ssato commented Sep 3, 2020

Make possible to run tests (python setup.py test) and other related
stuff (flake8, doc8 and yamllint) using tox.

Signed-off-by: Satoru SATOH satoru.satoh@gmail.com

@coveralls
Copy link

coveralls commented Sep 3, 2020

Coverage Status

Coverage remained the same at 97.867% when pulling 11d90dc on ssato:tox into 597e88b on adrienverge:master.

Make possible to run tests (python setup.py test) and other related
stuff (flake8, doc8 and yamllint) using tox.

Signed-off-by: Satoru SATOH <satoru.satoh@gmail.com>
@ssato
Copy link
Contributor Author

ssato commented Sep 4, 2020

I think that it doesn't break anything and just makes our hacking life easier by adding a feature to allow us testing it using just 'tox -e py36' command for example. So could you please take just a little time to looks this? I'm very happy if it's merged.

Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand it would save time for people that use tox, but not for others, and I try to keep the repo as simple as possible (for many reasons, including easy maintenance and easy bootstrapping for non-Python users).

I'm not favorable to this, sorry.

tox.ini Show resolved Hide resolved
@ssato
Copy link
Contributor Author

ssato commented Sep 8, 2020

I understand it would save time for people that use tox, but not for others, and I try to keep the repo as simple as possible (for many reasons, including easy maintenance and easy bootstrapping for non-Python users).

I'm not favorable to this, sorry.

I understand you want to keep it simple, however, let me try to explain why it's valuable and necessary for developers from my point of view, please.

  • Pros

    • Tox looks a de facto testing tool widely used and developers might be familiar with it already, I guess.

    • Tox is just needed for testing and users of yamllint are not affected at all by adding its dependency.

    • Tox does not only save time but also break down the barrier to develop and test yamllint.

    • Because runtime and test time dependencies are written in each dependent files separately, you can update them without affecting others as needed.

    • By using tox, you can simplify https://github.com/adrienverge/yamllint/blob/master/CONTRIBUTING.rst a lot; just ask developers to run tox should be enough.

    • Because my change just adds some files, that does not bring any risks, AFAIK.

    • Tox enables us testing in multiple virtual environments different python versions are installed at once easily without any specific CI services.

  • Cons

    • maintainance and learning costs: Although tox's configuration is very simple, it brings another test time dependency and force us to learn how to use it.

@ssato
Copy link
Contributor Author

ssato commented Sep 11, 2020

I opened another PR for this.

@ssato ssato closed this Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants