-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support no warnings in config #348
base: master
Are you sure you want to change the base?
Conversation
@adrienverge What do you think? |
Hello, I'm not sure what to think because I dont' know what "the no-warnings mode" is. Your commit doesn't say it, neither does it add documentation to explain this option. If it's somehow comparable to |
The documentation currently states:
|
Ah yes, sorry I forgot that. I'm not favorable to adding redundant options inside configuration. Conf already allows removing rules if their output is not wanted. Command-line arguments |
Hmmmm. That is unfortunate. We are trying to use this as part of our build and need no warnings enabled. If that was all, we wouldn’t need this feature. But, we are also trying to have Atom perform the same linting. Because this cannot be controlled via the config file, it is not possible to get the same behavior in both scenarios without manual configuration. |
11e5b12
to
5de2fff
Compare
Add support for including
no-warnings: true
orno-warnings: false
in the config file. If either the config fileno-warnings: true
or the cli option-no-warnings
are set, then no-warnings mode will be enabled.