setup: update python_requires to comply with PEP 345/440 #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienverge
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Thanks, it looks good!
Can you please add an explanation inside the commit message, e.g. copy-paste the description from #387? (it wasn't really needed to open an issue if you solve it directly).
According to [PEP 345 Requires-Python](https://www.python.org/dev/peps/pep-0345/#requires-python), the value of this field must be a valid [Version Specifier](https://www.python.org/dev/peps/pep-0345/#version-specifiers). Which in turn expects this to comply with [PEP 440](https://www.python.org/dev/peps/pep-0440/). While not an issue for those that directly use `pip`, this will cause issues for `poetry` users in the next release (if their current stance is maintained). Discussion of the issue and there stance can be found here: python-poetry/poetry#4095.
|
@adrienverge - sure thing. updated commit message pushed. |
|
Thank you @ITProKyle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to PEP 345 Requires-Python, the value of this field must be a valid Version Specifier. Which in turn expects this to comply with PEP 440.
While not an issue for those that directly use
pip, this will cause issues forpoetryusers in the next release (if their current stance is maintained). Discussion of the issue and there stance can be found here: python-poetry/poetry#4095.resolves #387