Associated Works for Zenodo Records #48
Conversation
…o 'versions' in parsed metadata to handle it returning as an array.
…Modified forward._build_nonbib_record to accept version records, and place bibcodes in the 'ASSOCIATED' data_link_row.
…bibcode to db_version_bibcodes as this bibcode will not be found in the public schema until it has finished being processed. generated initial skeleton for task_process_updated_associated_works
…ion from database and forward changes to master without calling the webhook.
… only added to new citations if other versions already exist in the db. Refactoring to make updating targets in the db easier.
…tuation where all_verions_doi is undefined due to doi not being defined, or parsed_metadata failing
… call to db.updated_citation_target_metadata() to task_process_update_associated_works().
…tadata check in task.py. Fixed error in column add for alembic version associated_works.
…ified _build_nonbib_record to properly include associate works. Fixed checks on versions to match expected output.
…te_associated_works.
tjacovich
force-pushed
the
associated_works
branch
from
93dc0da to
a559635
Compare
…rence in associated works for updated citations.
…ks. Minor formatting tweaks
| @@ -36,7 +36,7 @@ def store_event(app, data): | |||
| stored = True | |||
| return stored | |||
|
|
|||
| def store_citation_target(app, citation_change, content_type, raw_metadata, parsed_metadata, status): | |||
| def store_citation_target(app, citation_change, content_type, raw_metadata, parsed_metadata, status, associated=None): | |||
There was a problem hiding this comment.
Let's homogenize spaces before/after equal signs (choose the same style as Roman's cookie cutter tool)
There was a problem hiding this comment.
Homogenizing around no space when in function def or calls, but space when assigning to variable.
ADSCitationCapture/tasks.py
Outdated
| ) | ||
| #update associated works for all versions in db | ||
| logger.info('Calling task process_updated_associated_works') | ||
| task_process_updated_associated_works.delay(associated_citation_change, associated_version_bibcodes) |
There was a problem hiding this comment.
The function _collect_associated_works is calling task_process_updated_associated_works, it feels to me like not a specific simple function that does one thing (i.e., return some values) but two things (i.e., return some values and trigger further processing). I would split it in two, one gets the info and the other triggers the processing. That should make the code more readable.
There was a problem hiding this comment.
Broke these into two functions and moved the call for the processing to afters the citation target is stored so that way the new target is guaranteed to be in the database.
…emoved obsolete functions. Updated readme. Broke _collect_associated_works into two functions. Added additional documentation.
|
Formatting updates are largely complete, but need to wait to rebase on patched manual curation |
…ssociated works modifications to _update_citation_target_session.
…rks and curated metadata. Fixed bug in eval_associated introduced during rebasing.
…nittest for fetch_associated_works_doi().
Adds associated works to citation targets in database. Updates current citation targets when a new associated target is added. Adds maintenance task to find associated works for all entries. Includes associated works in forwarded messages to Master.