Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #22

Merged
merged 1 commit into from
Nov 4, 2015
Merged

Fixed typo #22

merged 1 commit into from
Nov 4, 2015

Conversation

andycasey
Copy link
Contributor

Also, this is awesome. I'm going to start adding code to make use of this functionality on the client end. I was just about to email you guys if there was going to be API access to libraries in the future, and then here we are!

Also, this is **awesome**. I'm going to start adding code to make use of this functionality on the client end. I was just about to email you guys if there was going to be API access to libraries in the future, and then here we are!
@jonnybazookatone
Copy link
Contributor

Thanks. If something isn't clear, let us know. Libraries are on accessible on BBB right now under your user account; http://adsabs.github.io/blog/ads-private-libraries/. Permissions in the UI should be included later, so some things might not be contextually clear.

I'm happy to contribute to the client if you open a branch specifically for the libraries.

jonnybazookatone added a commit that referenced this pull request Nov 4, 2015
@jonnybazookatone jonnybazookatone merged commit 138ebc2 into adsabs:master Nov 4, 2015
@andycasey
Copy link
Contributor Author

One question @jonnybazookatone: do you have a specific timeframe for when the old libraries will be transferred over to BBB? (And whether I'd be able to politely request for 1 or 2 old ones to be switched over early for "testing", rather than creating new ones)

@jonnybazookatone
Copy link
Contributor

We plan to have it in the near future, it's at the top of the list. If you want to do it already, and you're happy with playing with the API, you can go ahead and do it using your dev token.

You just need to send a post request to 'v1/biblib/libraries', that contains the 'name', 'description', and 'bibcode' list. This'll create the library and insert the relevant bibcodes. So, you just need to pull the relevant libraries from classic or ADS 2.0.

For ADS classic you can export them with a custom print statement that just outputs the bibcodes. For 2.0 I guess you can do it via the client you wrote (?).

As for testing, I'd suggest you stub the response from the libraries asap so that you don't reach the API limit during development. I'm happy to pass on the type of responses you would get.

@andycasey
Copy link
Contributor Author

Great, thanks @jonnybazookatone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants