Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more Barrels #542

Merged
merged 4 commits into from
Oct 4, 2024
Merged

No more Barrels #542

merged 4 commits into from
Oct 4, 2024

Conversation

thostetler
Copy link
Member

Get rid of the barrel files in components, lib, and break apart utils

This is part of an overall refactoring effort, trying to isolate pages and their modules and reduce side-effects.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 92.47312% with 77 lines in your changes missing coverage. Please review.

Project coverage is 51.9%. Comparing base (a597cdd) to head (c0b7925).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Orcid/helpers.ts 24.3% 25 Missing ⚠️
src/utils/common/formatters.ts 82.5% 20 Missing ⚠️
src/utils/common/guards.ts 93.0% 9 Missing ⚠️
src/utils/common/search.ts 96.1% 9 Missing ⚠️
src/utils/common/isValidEmail.ts 57.9% 8 Missing ⚠️
src/utils/common/coalesceAuthorsFromDoc.ts 95.9% 1 Missing and 1 partial ⚠️
src/utils/common/enumKeys.ts 85.8% 2 Missing ⚠️
...components/Libraries/DocumentList/DocumentItem.tsx 87.5% 1 Missing ⚠️
src/components/ResultList/Item/Item.tsx 85.8% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #542     +/-   ##
========================================
+ Coverage    46.3%   51.9%   +5.7%     
========================================
  Files         427     339     -88     
  Lines       46139   37865   -8274     
  Branches      630     621      -9     
========================================
- Hits        21347   19646   -1701     
+ Misses      24782   18209   -6573     
  Partials       10      10             
Files with missing lines Coverage Δ
src/api/export/types.ts 96.9% <100.0%> (+0.1%) ⬆️
src/api/objects/objects.ts 30.9% <100.0%> (ø)
src/api/orcid/models.ts 20.3% <100.0%> (ø)
src/api/orcid/orcid.ts 21.7% <100.0%> (ø)
src/api/search/search.ts 50.6% <100.0%> (ø)
src/components/AbstractSideNav/AbstractSideNav.tsx 22.0% <100.0%> (+1.0%) ⬆️
src/components/AbstractSources/AbstractSources.tsx 64.6% <100.0%> (+0.2%) ⬆️
src/components/AllAuthorsModal/AllAuthorsModal.tsx 19.8% <100.0%> (ø)
...mponents/AuthorAffiliations/AuthorAffiliations.tsx 17.5% <100.0%> (ø)
src/components/AuthorAffiliations/ErrorMessage.tsx 38.9% <100.0%> (ø)
... and 111 more

... and 95 files with indirect coverage changes

@thostetler thostetler merged commit 867e8c5 into adsabs:master Oct 4, 2024
4 checks passed
@thostetler thostetler deleted the no-more-barrels branch October 4, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant