Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API barrel file, alter linting setup to use next-lint by default #548

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

thostetler
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 75.55556% with 132 lines in your changes missing coverage. Please review.

Project coverage is 51.7%. Comparing base (a06d298) to head (d2fb2fb).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/components/BibstemPicker/BibstemPicker.tsx 35.0% 26 Missing ⚠️
src/lib/useSettings.ts 15.4% 22 Missing ⚠️
...mponents/EmailNotifications/Forms/KeywordsForm.tsx 11.8% 15 Missing ⚠️
src/pages/paper-form.tsx 42.2% 11 Missing ⚠️
src/components/AllAuthorsModal/AllAuthorsModal.tsx 30.0% 7 Missing ⚠️
.../components/EmailNotifications/Forms/ArxivForm.tsx 33.4% 4 Missing ⚠️
.../components/ResultList/Pagination/usePagination.ts 33.4% 4 Missing ⚠️
...lizations/Containers/ConceptCloudPageContainer.tsx 33.4% 4 Missing ⚠️
src/utils/common/search.ts 90.0% 4 Missing ⚠️
src/components/Libraries/LibraryListTable.tsx 40.0% 3 Missing ⚠️
... and 17 more
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #548     +/-   ##
========================================
- Coverage    52.0%   51.7%   -0.2%     
========================================
  Files         339     319     -20     
  Lines       37857   37697    -160     
  Branches      621     632     +11     
========================================
- Hits        19648   19469    -179     
- Misses      18199   18218     +19     
  Partials       10      10             
Files with missing lines Coverage Δ
src/api/api.ts 84.4% <100.0%> (+0.7%) ⬆️
src/api/biblib/libraries.ts 44.0% <100.0%> (-0.1%) ⬇️
src/api/biblib/types.ts 100.0% <100.0%> (ø)
src/api/export/export.ts 89.2% <100.0%> (+0.3%) ⬆️
src/api/export/types.ts 96.9% <100.0%> (-<0.1%) ⬇️
src/api/objects/objects.ts 32.0% <100.0%> (+1.2%) ⬆️
src/api/orcid/orcid.ts 22.1% <100.0%> (+0.5%) ⬆️
src/api/reference/reference.ts 55.0% <100.0%> (+2.4%) ⬆️
src/api/search/models.ts 40.5% <100.0%> (ø)
src/api/search/search.ts 49.8% <100.0%> (-0.7%) ⬇️
... and 132 more

... and 9 files with indirect coverage changes

@thostetler thostetler merged commit 0fd95ae into adsabs:master Oct 24, 2024
5 checks passed
@thostetler thostetler deleted the no-more-barrels-1 branch October 24, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant