Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gpn_id with planetary_feature_id #571

Merged

Conversation

thostetler
Copy link
Member

@thostetler thostetler commented Dec 7, 2024

image

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.1%. Comparing base (a74fabc) to head (45746b1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/api/search/models.ts 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #571     +/-   ##
========================================
+ Coverage    66.1%   66.1%   +0.1%     
========================================
  Files         197     197             
  Lines       22146   22146             
  Branches      585     585             
========================================
+ Hits        14625   14627      +2     
+ Misses       7511    7509      -2     
  Partials       10      10             
Files with missing lines Coverage Δ
src/api/models.ts 100.0% <100.0%> (ø)
src/api/search/types.ts 100.0% <100.0%> (ø)
src/api/search/models.ts 36.1% <0.0%> (ø)

... and 1 file with indirect coverage changes

@thostetler thostetler merged commit e4d1e78 into adsabs:master Dec 7, 2024
4 checks passed
@thostetler thostetler deleted the use-planetaryfeatureid-instead-of-gpnid branch December 7, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant