conda_mirror.py: log download errors instead of breaking and clearing… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parente
reviewed
Sep 27, 2018
conda_mirror/conda_mirror.py
Outdated
| _download(url, download_dir) | ||
| summary['downloaded'].add((url, download_dir)) | ||
| except: | ||
| logger.error('Unexpected error: %s. Aborting download.', sys.exc_info()[0]) |
There was a problem hiding this comment.
Maybe rendering the full stack trace with logger.exception('Unexpected error: Aborting download') would be better here?
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
- Coverage 96.88% 93.89% -3%
=======================================
Files 2 2
Lines 257 262 +5
=======================================
- Hits 249 246 -3
- Misses 8 16 +8
Continue to review full report at Codecov.
|
parente
reviewed
Oct 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default conda-mirror will continue pulling files until it either succeeds or dies from some sort of error.
If an error is encountered, all downloaded files residing in "temp space" will be deleted.
This change logs exceptions that occur during download so that the files that actually download successfully will be verified and moved to the target folder.