Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading library name from .fd file #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tehKaiN
Copy link

@tehKaiN tehKaiN commented Apr 16, 2021

Related to bebbo/amiga-gcc#214

Currently, the library filename is taken from two sources:

  • if .fd file name is xxx_lib.fd, use xxx as library name
  • otherwise, extract library name from librarybase variable defined inside .fd file

This wasn't warking for http://aminet.net/package/util/libs/Identify because it resulted in trying to load "Identify.library" instead of "identify.library". Amiga's OpenLibrary() opens the file and does the case-sensitive strcmp of the library name coded inside the file.

New code works similarly to the old version:

  • if .fd file name is xxx_lib.fd, use xxx as library name
  • otherwise, assume that the library name is same as full .fd file name

This probably also fixes CyberGraphics pack - it will try to open cybergraphics.library instead of CyberGfx.library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant