Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error during assembly in Form for different mesh- and field-dimensions #675

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Mar 4, 2024

fixes #674

Also changed within this PR

adtzlr added 4 commits March 4, 2024 23:34
...during assembly in `fem.assembly.expression.Form` for the integration of a linear form with different mesh- and field-dimensions.
with `FormItem(bilinearform=None, linearform=None)`
@adtzlr adtzlr added the bug Something isn't working label Mar 4, 2024
@adtzlr adtzlr self-assigned this Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.88%. Comparing base (8243d74) to head (3001917).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   96.85%   96.88%   +0.02%     
==========================================
  Files          94       94              
  Lines        4963     4970       +7     
==========================================
+ Hits         4807     4815       +8     
+ Misses        156      155       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adtzlr adtzlr merged commit 6fa4c34 into main Mar 4, 2024
8 of 9 checks passed
@adtzlr adtzlr deleted the fix-form-wrong-shape branch March 4, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant