Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tools.topoints(values, region) #712

Merged
merged 7 commits into from
Mar 17, 2024
Merged

Simplify tools.topoints(values, region) #712

merged 7 commits into from
Mar 17, 2024

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Mar 17, 2024

This removes all other arguments from topoints(values, region).

See also #711

@adtzlr adtzlr added enhancement New feature or request consistency All tasks towards consistent namings for similar tasks labels Mar 17, 2024
@adtzlr adtzlr added this to the 8.0 milestone Mar 17, 2024
@adtzlr adtzlr self-assigned this Mar 17, 2024
@adtzlr adtzlr changed the title Simplify tools.topoints() Simplify tools.topoints(values, region) Mar 17, 2024
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.31%. Comparing base (62f3d3e) to head (7de6818).

❗ Current head 7de6818 differs from pull request most recent head ffaac54. Consider uploading reports for the commit ffaac54 to get more accurate results

Files Patch % Lines
src/felupe/tools/_project.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   97.35%   97.31%   -0.05%     
==========================================
  Files          94       94              
  Lines        5060     5057       -3     
==========================================
- Hits         4926     4921       -5     
- Misses        134      136       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adtzlr adtzlr merged commit 94d83d8 into main Mar 17, 2024
6 of 7 checks passed
@adtzlr adtzlr deleted the simplify-topoints branch March 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency All tasks towards consistent namings for similar tasks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant