Outsource EvaluateFieldContainer to field/_evaluate.py
#729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adtzlr
changed the title
EvaluateFieldContainer from field._container.py to field._evaluate.pyEvaluateFieldContainer from field/_container.py to field/_evaluate.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 94 95 +1
Lines 5152 5155 +3
=======================================
+ Hits 5019 5022 +3
Misses 133 133 ☔ View full report in Codecov by Sentry. |
adtzlr
changed the title
EvaluateFieldContainer from field/_container.py to field/_evaluate.pyEvaluateFieldContainer to field/_evaluate.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and use
FieldContainer.evaluatemethods inViewFieldinstead of direct calls to the math-methods.This is just an internal change - does not change the public API.