Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the number of points for non-disconnected dual-meshes #867

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Oct 21, 2024

closes #866

@adtzlr adtzlr added the bug Something isn't working label Oct 21, 2024
@adtzlr adtzlr self-assigned this Oct 21, 2024
@adtzlr adtzlr merged commit c07d0a9 into main Oct 21, 2024
6 checks passed
@adtzlr adtzlr deleted the fix-npoints-dual-mesh-connected branch October 21, 2024 15:18
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (e04456a) to head (ff5dd49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   97.55%   97.54%   -0.02%     
==========================================
  Files         149      149              
  Lines        5736     5739       +3     
==========================================
+ Hits         5596     5598       +2     
- Misses        140      141       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The number of points for dual meshes is wrong for disconnect=False
1 participant