fix(rust): allocation not working #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for wasm4 ready! 🔨 Explore the source changes: 6885d97 🔍 Inspect the deploy log: https://app.netlify.com/sites/wasm4/deploys/6151fdb54664b800087878f2 😎 Browse the preview: https://deploy-preview-111--wasm4.netlify.app |
Description Improves ergonomics of trace and text via `T : AsRef<T>` generic. References: - https://doc.rust-lang.org/std/convert/trait.AsRef.html - https://doc.rust-lang.org/src/alloc/string.rs.html#2483 - https://doc.rust-lang.org/std/string/struct.String.html#impl-AsRef%3C%5Bu8%5D%3E
aduros
reviewed
Sep 26, 2021
aduros
reviewed
Sep 26, 2021
aduros
reviewed
Sep 26, 2021
aduros
reviewed
Sep 26, 2021
Other changes: * bump -zstack-size to 8624 * remove trailing whitespaces
|
Bummer that Thanks so much for your work on this! It's great to finally have dynamic memory allocation all sorted out across all 4 supported wasm languages. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds buddy-alloc as optional default allocator and increases the stack size.
Issues
textortraceandformat!throwsRuntimeError: unreachable executed#36Related PR
See also
--import-memoryrustwasm/wasm-bindgen#1389 (comment)