Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid errors with an old cmake used on libretro CI #769

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Oct 8, 2024

Fixes #768

yamt referenced this pull request Oct 8, 2024
@yamt yamt mentioned this pull request Oct 8, 2024
@warmenhoven
Copy link

Unfortunately this doesn't seem to have fixed it:

https://git.libretro.com/libretro/wasm4/-/pipelines/305380

@warmenhoven
Copy link

Looks like it just needs a similar if() wrapper around the one on line 217.

@yamt
Copy link
Contributor Author

yamt commented Oct 8, 2024

Looks like it just needs a similar if() wrapper around the one on line 217.

oops, thank you. fixed.

@LibretroAdmin
Copy link

Can this be merged @aduros ? We need it for the buildbot

@aduros
Copy link
Owner

aduros commented Oct 10, 2024

Thanks @yamt !

@aduros aduros merged commit 63a0648 into aduros:main Oct 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Libretro buildbot failures
4 participants