Skip to content

Conversation

Perdiga
Copy link

@Perdiga Perdiga commented Sep 17, 2025

This resolves: #227

The documented workflow fails to upload the SARIF file because it references the wrong property, causing the file not to be found. This update corrects that issue.

This resolves: advanced-security#227

The documented workflow fails to upload the SARIF file because it references the wrong property, causing the file not to be found. This update corrects that issue.
@github-actions github-actions bot added the docs label Sep 17, 2025
@Perdiga Perdiga marked this pull request as ready for review September 18, 2025 18:48
@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 18:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a documentation issue in the workflow example where the SARIF file upload was failing due to incorrect property references. The fix ensures the workflow properly uploads CodeQL analysis results.

  • Updates the step ID from codeql_iac to codeql for consistency
  • Corrects the SARIF file reference from sarif to sarif-results to match the actual output property
  • Adds configuration to preserve the CodeQL tool name in SARIF output

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Output sarif is wrong when using on github actions

3 participants