Cover missing XSS vulnerability #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Model `Router.getTarget()`, 2. Model `DisplayEventHandler` (as 0-th argument to `attachDisplay` and `detachDisplay` method calls) 3. Model `DisplayEventHandler`'s 0-th parameter as `DisplayEventHandlerParameterAccess` in `RemoteFlowSources.qll`
mbaluda
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR contributes
Cover new XSS vulnerability
Cover an XSS vulnerability previously not covered, which required these changes:
sap.ui.core.routing.Target.attachDisplayshould also be recognized asEventHandlers, on top of the methods of custom controllers.DisplayEventHandlerclass extending theEventHandlersclass, which covers the abovesap.ui.core.routing.Target.attachDisplay.sap.base.i18n.ResourceBundle.getTextto its return value should be recognized.PropertyMetadata.getARead, andPropertyMetadata.getAWriteshould be more restricted to remove spurious flows.Add new tests
Bump versions
Limitations
The two APIs,
sap.ui.core.routing.Target.attachDisplayandsap.base.i18n.ResourceBundle.getText, cannot be expressed as MaD rows since the type of the object thatthispoints to cannot be resolved using MaD. The former is obtained via access paththis.getOwnerComponent().getRouter().getTarget("...").attachDisplay()and the latter viathis.getOwnerComponent().getModel("...").getResourceBundle(). Here, boththispoints to thesap.ui.core.Componentthat is being imported, and the relationship between the two cannot be automatically resolved through the mechanism used in MaD.Future Work
If possible:
sap.base.i18n.ResourceBundle.getTextandsap.ui.core.routing.Target.attachDisplay, respectively.