Skip to content

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Aug 28, 2024

Adds 2 queries and related tests:

  • Broken XSJS authentication
  • Disabled XSJS CSRF protection

@mbaluda mbaluda self-assigned this Aug 28, 2024
@mbaluda mbaluda requested a review from jeongsoolee09 August 28, 2024 20:59
```

## References

Copy link
Contributor

@jeongsoolee09 jeongsoolee09 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to the documentation page about xs-app.json may be a useful addition: https://help.sap.com/docs/SAP_HANA_PLATFORM/4505d0bdaf4948449b7f7379d24d0f0d/5f77e58ec01b46f6b64ee1e2afe3ead7.html

Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're off to a good start! I've left some thoughts here and there.

mbaluda and others added 3 commits September 4, 2024 12:46
Co-authored-by: Jeongsoo Lee <jeongsoolee09@github.com>
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeongsoolee09 jeongsoolee09 merged commit 4b2580a into main Sep 4, 2024
5 checks passed
@jeongsoolee09 jeongsoolee09 deleted the mbaluda/xsjs-access branch September 4, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants