Capture and report CDS compilation errors #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a compilation failure in CDS non-fatal, instead capturing and reporting the error via the tool status page in GitHub.
|
LGTM! |
jeongsoolee09
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation failures in CDS files were previously considered fatal. However, we have seen CAP projects which have old or unused CDS files, where it would be undesirable to block the whole analysis.
This PR therefore makes a compilation failure in CDS non-fatal, instead capturing and reporting the error via the diagnostics for CodeQL, which will ultimately appear on the tool status page in GitHub, e.g.: