Skip to content

Conversation

jeongsoolee09
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 commented Sep 18, 2025

What This PR Contributes

This PR removes the diagnostic query ListXssPartialPaths. This decision is made based on the following objections:

  1. The partial paths are subject to change as the underlying data flow library evolves. This means the test breakage can come from the standard library and not our code.
  2. If the model-as-data summaryModel predicate needs to be tested, this query can be trimmed down to target the predicate directly (or in a more reader-friendly way, using ModelsAsData::SummarizedCallableFromModel.getACall/0 or summaryStep / summaryStepNodes from the same module).
  3. The query depends on the outdated data flow APIs.

Future Works

N/A

@data-douser
Copy link
Collaborator

@jeongsoolee09 Regarding your second objection (from PR description), does removing this diagnostics query in any way leave a new (or increased) gap in our testing of the models-as-data summaryModel predicate? If not, is there some form of test for summaryModel that we might want to improve in the future (and track now via a new issue)?

Copy link
Collaborator

@data-douser data-douser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending resolution of one comment / question. Other than that, LGTM!

@jeongsoolee09
Copy link
Contributor Author

@data-douser No, it's closer to a supposed scenario where summaryModel ever needs to be tested. It is currently not tested anywhere in the codebase.

@data-douser data-douser merged commit 0718315 into main Sep 19, 2025
5 checks passed
@data-douser data-douser deleted the jeongsoolee09/remove-list-xss-partial-paths branch September 19, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants