-
Notifications
You must be signed in to change notification settings - Fork 2
Bump version: 1.0.0 and 1.0.1 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to make the extension target version explicit and it seems the CodeQL test workflow failed 😿
@jeongsoolee09 I do not think we should exclude @rvermeulen the test issue was there already but now the workflow checks the status and fails accordingly. We can safely ignore it for this PR... |
@jeongsoolee09 did you push everything? The change does not seem to match the description... |
@mbaluda |
As they are not included in the first place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
advanced-security/javascript-sap-ui5-extensions
) from 0.0.1 to 0.1.0advanced-security/javascript-sap-ui5-queries
) from 0.0.1 to 0.1.0advanced-security/javascript-sap-ui5-extensions
as dependency ("^0.1.1"
) ofadvanced-security/javascript-sap-ui5-queries
so that they can be installed togethercodeql/javascript-all
among the both to"^0.6.3"
Excludejs/log-injection
,js/missing-x-frame-options
, andjs/xss
, assuming the customer's going to run the default JavaScript query suite along our suite0.1.0