-
Notifications
You must be signed in to change notification settings - Fork 2
Add sarif-diff to Code Scanning workflow #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
If will change the structure in our restructuring PR to make it UI5 specific.
See the code comment for info on the request change.
Code itself looks good, but does this mean we should keep |
Also, it might be nice if we can replace |
Yes! After reviewing the diff, one would typically replace the SARIF with the one in the action artefacts like here: |
FIxes #57
Adds steps to the Code Scanning workflow checking that the new SARIF file matches the expected one stored in
.github/workflows/javascript.sarif.expected
.If there is a mismatch, the new SARIF and a diff are uploaded as artefacts to eventually update the
.expected
fileExamples of passing and failing runs:
✅ https://github.com/advanced-security/codeql-sap-js/actions/runs/7787950054
❌ https://github.com/advanced-security/codeql-sap-js/actions/runs/7787745458