Skip to content

Broaden the requirements for an XML view #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Broaden the requirements for an XML view #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 37 additions & 5 deletions javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5View.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,12 +399,44 @@ class XmlBindingPath extends UI5BindingPath instanceof XmlAttribute {
}
}

class XmlRootElement extends XmlElement {
XmlRootElement() { any(XmlFile f).getARootElement() = this }

/**
* Returns a XML namespace declaration scoped to the element.
*
* The predicate relies on location information to determine the scope of the namespace declaration.
* A XML element with the same starting line and column, but a larger ending line and column is considered the
* scope of the namespace declaration.
*/
XmlNamespace getANamespaceDeclaration() {
exists(Location elemLoc, Location nsLoc |
elemLoc = this.getLocation() and
nsLoc = result.getLocation()
|
elemLoc.getStartLine() = nsLoc.getStartLine() and
elemLoc.getStartColumn() = nsLoc.getStartColumn() and
(
elemLoc.getEndLine() > nsLoc.getEndLine()
or
elemLoc.getEndLine() = nsLoc.getEndLine() and
elemLoc.getEndColumn() > nsLoc.getEndColumn()
)
)
}
}

class XmlView extends UI5View, XmlFile {
XmlElement root;
XmlRootElement root;

XmlView() {
root = this.getARootElement() and
root.getNamespace().getUri() = "sap.ui.core.mvc" and
(
root.getNamespace().getUri() = "sap.ui.core.mvc"
or
root.getNamespace().getUri() = "sap.ui.core" and
root.getANamespaceDeclaration().getUri() = "sap.ui.core.mvc"
) and
root.hasName("View")
}

Expand Down Expand Up @@ -510,7 +542,7 @@ abstract class UI5Control extends Locatable {
CustomController getController() { result = this.getView().getController() }
}

class XmlControl extends UI5Control, XmlElement {
class XmlControl extends UI5Control instanceof XmlElement {
XmlControl() { this.getParent+() = any(XmlView view) }

/** Get the qualified type string, e.g. `sap.m.SearchField` */
Expand All @@ -523,11 +555,11 @@ class XmlControl extends UI5Control, XmlElement {
result = any(CustomControl control | control.getName() = this.getQualifiedType())
}

override Location getLocation() { result = XmlElement.super.getLocation() }
override Location getLocation() { result = this.(XmlElement).getLocation() }

override XmlFile getFile() { result = XmlElement.super.getFile() }

override UI5ControlProperty getAProperty(string name) { result = this.getAttribute(name) }
override UI5ControlProperty getAProperty(string name) { result = this.(XmlElement).getAttribute(name) }

override CustomControl getDefinition() {
result.getName() = this.getQualifiedType() and
Expand Down