Expand javascript bindings #73
Conversation
The binding contains the target being bound, so this allows use to track the binding target for each binding path. This helps in cases where we couldn't easily get this information causing a cross product if multiple bindings or paths were the same.
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/Bindings.qll
Show resolved
Hide resolved
| } or | ||
| // Json binding | ||
| TJsonPropertyBinding(JsonObject object, string key, StaticBindingValue binding) { | ||
| TJsonPropertyBinding(JsonObject object, string propertyName, StaticBindingValue binding) { |
There was a problem hiding this comment.
TJsonPropertyBinding is not capturing "{/input}" (both in line 9 and 13) in app.view.json on my environment. Could you look into it?
There was a problem hiding this comment.
When I run them on a database on the test files I find them. It would also mean that
would fail and it doesn't. Are you sure that it is not captured?
There was a problem hiding this comment.
Upon quick-evaluating / debugging variants of TBinding and TBindingTarget, I found that:
TXmlContextBindingTargettogether withTXmlContextBinding: Are the attributes namedbindingtreated specially? Could you point me to a relevant portion of documentation?TJsonPropertyBindingTargettogether withTJsonPropertyBinding: As pointed out in a separate comment, there are bits ofapp.view.jsonthat are not being captured.TLateJavaScriptPropertyBinding: These yield an empty relation, too.
Yes, these are called context bindings. See https://ui5.sap.com/#/topic/91f05e8b6f4d1014b6dd926db0e91070
Empty releation on what? We have test cases that pass. See |
|
@rvermeulen Sorry, now I get results from the three relations in question. |
Include binding arbitrary JavaScript properties for JS views.