Skip to content

Conversation

knewbury01
Copy link
Contributor

adds a model for the expression parsing API calls and a simple unit test

@knewbury01 knewbury01 requested a review from mbaluda January 30, 2024 21:50
@knewbury01 knewbury01 self-assigned this Jan 30, 2024
@knewbury01 knewbury01 enabled auto-merge January 30, 2024 21:51
@@ -0,0 +1,5 @@
const cds = require("@sap/cds");

let cxn = cds.parse.expr (`foo.bar > 9`)

Check notice

Code scanning / CodeQL

Unused variable, import, function or class

Unused variable cxn.
const cds = require("@sap/cds");

let cxn = cds.parse.expr (`foo.bar > 9`)
let xpr = cds.parse.xpr (`foo.bar > 9`)

Check notice

Code scanning / CodeQL

Unused variable, import, function or class

Unused variable xpr.

let cxn = cds.parse.expr (`foo.bar > 9`)
let xpr = cds.parse.xpr (`foo.bar > 9`)
let ref = cds.parse.ref (`foo.bar`)

Check notice

Code scanning / CodeQL

Unused variable, import, function or class

Unused variable ref.
Copy link
Contributor

@mbaluda mbaluda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@knewbury01 knewbury01 merged commit b0754d6 into main Jan 31, 2024
@knewbury01 knewbury01 deleted the knewbury01/extra-cds-sinks-code-injection branch January 31, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants