Skip to content

Edit dependencies, precision and suite file names #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 8, 2024
Merged

Edit dependencies, precision and suite file names #91

merged 9 commits into from
Feb 8, 2024

Conversation

jeongsoolee09
Copy link
Contributor

No description provided.

@jeongsoolee09 jeongsoolee09 marked this pull request as ready for review February 8, 2024 00:10
@jeongsoolee09 jeongsoolee09 requested review from rvermeulen and mbaluda and removed request for rvermeulen February 8, 2024 00:10
@jeongsoolee09
Copy link
Contributor Author

Confirmed that:

  • Run our javascript-code-scanning.qls and see if the results exclude js/path-injection, js/log-injection, js/formula-injection, and js/clickjacking
  • Run our javascript-security-extended.qls and see if the results include everything

rvermeulen
rvermeulen approved these changes Feb 8, 2024
View reviewed changes
Copy link

@rvermeulen rvermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeongsoolee09 jeongsoolee09 merged commit c4e785e into main Feb 8, 2024
@jeongsoolee09 jeongsoolee09 deleted the jeongsoolee09/deps-precision-suite branch February 8, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbaluda mbaluda Awaiting requested review from mbaluda

1 more reviewer

@rvermeulen rvermeulen rvermeulen approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeongsoolee09 @rvermeulen @mbaluda