-
Notifications
You must be signed in to change notification settings - Fork 2
Cover multi-service log injection #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Normalize import path to `advanced_security.javascript.frameworks.cap`. - Remove wrapping CDS / CQL inner module declaration.
Either by: - Fixing module paths, or - Using newer classes
`await` was unexpected in this context.
javascript/frameworks/cap/test/queries/loginjection/sample-app/srv/service2.js
Fixed
Show fixed
Hide fixed
...frameworks/cap/test/queries/loginjection/log-injection-without-protocol-none/srv/service2.js
Fixed
Show resolved
Hide resolved
It also trims whitespaces.
…advanced-security/codeql-sap-js into jeongsoolee09/cover-multi-service-log-i
This reverts commit 3406c27.
add `LGTM_INDEX_FILTERS: "include:**/*.json"` just in case
1. Ensure presence of cds shell command 2. Compile CAP CDS files 3. Initialize CodeQL 4. Perform CodeQL Analysis
…advanced-security/codeql-sap-js into jeongsoolee09/cover-multi-service-log-i
This reverts commit 3c0d822.
mbaluda
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR contributes
Add five additional log injection cases
log-injection-without-protocol-none
True positive case with two problematic flows.
log-injection-with-service1-protocol-none
True positive case with one problematic flow.
log-injection-with-service2-protocol-none
True positive case with one problematic flow.
log-injection-with-complete-protocol-none
False positive case with no problematic flows.
log-injection-not-depending-on-request
False positive case with no problematic flows.
Datetime
object and sends send2 of Service2 with itAdd more vocabularies
.cds
files compiled to.json
"cds"
section of thepackage.json
file.Move definitions to
dataflow
directoryThis is to more closely resemble the structure of the standard library's.
dataflow/DataFlow.qll
, whose import path isadvanced_security.javascript.frameworks.cap.dataflow.DataFlow
, contains all security-relatedDataFlow::Node
s or relations between them.dataflow/FlowSteps.qll
, whose import path isadvanced_security.javascript.frameworks.cap.dataflow.FlowSteps
, contains additional flow steps to be registered toDataFlow::SharedFlowStep
.Move log injection customizations to
CAPLogInjectionQuery.qll
This is to more closely resemble the structure of the standard library's.