Skip to content

Commit a955cfb

Browse files
authored
Merge pull request #10 from advanced-security/fix-quality
Fix quality
2 parents ebce1b9 + 39ad44e commit a955cfb

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

enrich_code_scanning_alerts.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
from typing import Any
1717
from pathlib import Path
1818
from datetime import datetime, timezone
19-
import time
2019
from mistletoe import markdown
2120
import humanize
2221
from defusedcsv import csv
@@ -60,7 +59,7 @@ def fixup_rule_metadata_codeql(rule_metadata: dict) -> None:
6059
rule_metadata["security-severity"] = float(
6160
rule_metadata["security-severity"]
6261
)
63-
except:
62+
except (FloatingPointError, ValueError):
6463
LOG.warning(
6564
"Could not parse security-severity in rule %s as float: %s",
6665
rule_metadata.get("id", "unknown ID"),

list_secret_scanning_alerts.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,14 +242,16 @@ def list_secret_scanning_alerts(
242242
alerts = decorate_alerts(g, alerts, include_locations=include_locations, include_commit=include_commit)
243243

244244
if raw:
245-
return alerts
245+
for alert in alerts:
246+
yield alert
247+
return None
246248
else:
247249
for alert in alerts:
248250
result = make_result(g, alert, scope, name, include_secret=include_secret, include_locations=include_locations, include_commit=include_commit)
249251
if result is not None:
250252
yield result
251253
else:
252-
return
254+
return None
253255

254256

255257
def add_args(parser: argparse.ArgumentParser) -> None:

0 commit comments

Comments
 (0)