Skip to content

Fix quality #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

Fix quality #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63abef4
Specific error handling for float errors
aegilops Nov 18, 2025
39ad44e
Correct implicit return
aegilops Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions enrich_code_scanning_alerts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
from typing import Any
from pathlib import Path
from datetime import datetime, timezone
import time
from mistletoe import markdown
import humanize
from defusedcsv import csv
Expand Down Expand Up @@ -60,7 +59,7 @@ def fixup_rule_metadata_codeql(rule_metadata: dict) -> None:
rule_metadata["security-severity"] = float(
rule_metadata["security-severity"]
)
except:
except (FloatingPointError, ValueError):
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FloatingPointError is not the appropriate exception to catch here. The float() function raises ValueError when it cannot parse the input string, not FloatingPointError. FloatingPointError is only raised during floating-point arithmetic operations (like division by zero with floating-point numbers), not during string-to-float conversion. The correct exception handling should be except ValueError: only.

Suggested change
except (FloatingPointError, ValueError):
except ValueError:

Copilot uses AI. Check for mistakes.
LOG.warning(
"Could not parse security-severity in rule %s as float: %s",
rule_metadata.get("id", "unknown ID"),
Expand Down
6 changes: 4 additions & 2 deletions list_secret_scanning_alerts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,14 +242,16 @@ def list_secret_scanning_alerts(
alerts = decorate_alerts(g, alerts, include_locations=include_locations, include_commit=include_commit)

if raw:
return alerts
for alert in alerts:
yield alert
return None
else:
for alert in alerts:
result = make_result(g, alert, scope, name, include_secret=include_secret, include_locations=include_locations, include_commit=include_commit)
if result is not None:
yield result
else:
return
return None


def add_args(parser: argparse.ArgumentParser) -> None:
Expand Down
Loading