Skip to content

Conversation

@mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Apr 27, 2023

GITHUB_API_ENDPOINT is not defined in the runner but it's instead GITHUB_API_URL

@mbaluda mbaluda requested a review from some-natalie as a code owner April 27, 2023 10:15
Copy link

@some-natalie some-natalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mbaluda ! Thanks!!!

You're 💯 right here. The reason I'd originally had it not be the GITHUB_API_URL is because I was using GitHub.com Actions runners to scrape data and test from private GHES instances - so it wasn't assumed to be looking at the version of GitHub that the runner was attached to.

I don't think this is a common use case for users though and I can always add overrides for testing it against GHES, so am going to :shipit:

Thanks again!!

@some-natalie some-natalie merged commit b73850f into advanced-security:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants