This repository has been archived by the owner on May 21, 2024. It is now read-only.
Generate for each role own key #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattivacek
reviewed
Dec 10, 2018
src/aktualizr_repo/repo.h
Outdated
| class Repo { | ||
| public: | ||
| Repo(boost::filesystem::path path, const std::string &expires, std::string correlation_id); | ||
| Repo(std::string repo_type, boost::filesystem::path path, const std::string &expires, std::string correlation_id); |
There was a problem hiding this comment.
It might be nice if repo_type was an enum class, although since you use the actual text for various reasons, perhaps it makes sense to have conversion functions to strings.
src/aktualizr_repo/repo.h
Outdated
| boost::filesystem::path path_; | ||
| std::string correlation_id_; | ||
| std::string expiration_time_; | ||
| std::map<std::string, KeyPair> keys_; |
There was a problem hiding this comment.
Another thought: instead of using a string as the key of this map, would it be better to use a KeyType?
src/aktualizr_repo/director_repo.cc
Outdated
| const boost::filesystem::path current = path_ / "repo/director/targets.json"; | ||
| const boost::filesystem::path staging = path_ / "repo/director/staging/targets.json"; | ||
|
|
||
| // |
patriotyk
force-pushed
the
feat/aktualizr-repo-keys
branch
from
b8a989e to
bdd29fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
==========================================
+ Coverage 82.31% 82.43% +0.11%
==========================================
Files 189 195 +6
Lines 13663 13790 +127
==========================================
+ Hits 11247 11368 +121
- Misses 2416 2422 +6
Continue to review full report at Codecov.
|
patriotyk
force-pushed
the
feat/aktualizr-repo-keys
branch
4 times, most recently
from
e20c212 to
8a6e695
Compare
Signed-off-by: Serhiy Stetskovych <patriotyk@gmail.com>
patriotyk
force-pushed
the
feat/aktualizr-repo-keys
branch
from
8a6e695 to
e90f1e7
Compare
Signed-off-by: Serhiy Stetskovych <patriotyk@gmail.com>
|
Looks promising. I like the enum classes! I just realized that What's missing is testing:
@OYTIS I'm also curious if this matches your expectations so far as well! |
Signed-off-by: Serhiy Stetskovych <patriotyk@gmail.com>
patriotyk
force-pushed
the
feat/aktualizr-repo-keys
branch
from
c1e65d6 to
ef59fce
Compare
Signed-off-by: Serhiy Stetskovych <patriotyk@gmail.com>
Signed-off-by: Serhiy Stetskovych <patriotyk@gmail.com>
patriotyk
force-pushed
the
feat/aktualizr-repo-keys
branch
from
7f9cbd4 to
c10c7ed
Compare
|
Looks like it should be ok now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.