OTA-2480: Remove OPC-UA and move IpUptaneSecondary out of libaktualizr #1177
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1177 +/- ##
==========================================
+ Coverage 77.88% 77.92% +0.04%
==========================================
Files 170 170
Lines 10052 10007 -45
==========================================
- Hits 7829 7798 -31
+ Misses 2223 2209 -14
Continue to review full report at Codecov.
|
…ktualizr Signed-off-by: Mike Sul <ext-mykhaylo.sul@here.com>
Signed-off-by: Mike Sul <ext-mykhaylo.sul@here.com>
mike-sul
force-pushed
the
refact/OTA-2292/IpUptane-and-OPCUA-secondaries
branch
from
7dae8cc to
f798e2c
Compare
mike-sul
changed the title
|
OPC-UA removal looks good. Thanks! |
Signed-off-by: Mike Sul <ext-mykhaylo.sul@here.com>
Yeah, and I didn't add or updated any line of source code, just adjusted some CMakeLists.txt |
| @@ -59,7 +58,7 @@ unset(AKTUALIZR_CHECKED_SRCS CACHE) | |||
| set(CMAKE_POSITION_INDEPENDENT_CODE ON) | |||
|
|
|||
| # find all required libraries | |||
| set(BOOST_COMPONENTS log_setup log filesystem program_options) | |||
| set(BOOST_COMPONENTS log_setup log system filesystem program_options) | |||
There was a problem hiding this comment.
Why did we need to re-add the system boost library?
There was a problem hiding this comment.
Oh, sorry, I forgot to answer to this question in the first place.
I couldn't link aktualizr-check-discovery without it, got linkage error saying that some boost symbol is not found.
I will double check it.
There was a problem hiding this comment.
Not a big deal at all. And anyway, we may get rid of that tool in the end anyway; I just made a subtask to investigate if it is still useful in the new scheme.
Signed-off-by: Mike Sul ext-mykhaylo.sul@here.com