This repository has been archived by the owner on May 21, 2024. It is now read-only.
Revert stripping of executable in release mode #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was added in 299475f to fix some .deb lint warning (lintian), but bitbake doesn't like it. Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
|
I'm in favor of this, but even better would be to do the stripping only for the debian packaging. You think that's possible? |
lintian reports non-stripped executables as warnings Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
|
Ok, I've added a slightly ugly way to do it |
pattivacek
approved these changes
Jun 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #1234 +/- ##
==========================================
+ Coverage 79.22% 79.59% +0.36%
==========================================
Files 170 170
Lines 10123 10123
==========================================
+ Hits 8020 8057 +37
+ Misses 2103 2066 -37
Continue to review full report at Codecov.
|
Zee314159
pushed a commit
that referenced
this pull request
Jun 19, 2019
Revert stripping of executable in release mode
Zee314159
pushed a commit
that referenced
this pull request
Jun 20, 2019
Revert stripping of executable in release mode
Zee314159
pushed a commit
that referenced
this pull request
Jun 21, 2019
Revert stripping of executable in release mode
Zee314159
pushed a commit
that referenced
this pull request
Jun 21, 2019
Revert stripping of executable in release mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was added in 299475f to fix some .deb
lint warning (lintian), but bitbake doesn't like it.