For OTA-2712, remove test repo meta

[xcheng-here]

remove test repo meta from test/test_data/repo,
generate data from test code using aktualizr-repo

Signed-off-by: cheng.xiang ext-cheng.xiang@here.com

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@b8c7952). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1239   +/-   ##
=========================================
  Coverage          ?   79.49%           
=========================================
  Files             ?      168           
  Lines             ?    10144           
  Branches          ?        0           
=========================================
  Hits              ?     8064           
  Misses            ?     2080           
  Partials          ?        0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c7952...2289973. Read the comment docs.

[lbonn]

For the failure in test_uptane_secondary, it looks like we missed some checks in Crypto::ED25519Verify. I would try something like that:

diff --git a/src/libaktualizr/crypto/crypto.cc b/src/libaktualizr/crypto/crypto.cc
index 8f9f16db..33027b44 100644
--- a/src/libaktualizr/crypto/crypto.cc
+++ b/src/libaktualizr/crypto/crypto.cc
@@ -226,6 +226,9 @@ bool Crypto::RSAPSSVerify(const std::string &public_key, const std::string &sign
   return status == 1;
 }
 bool Crypto::ED25519Verify(const std::string &public_key, const std::string &signature, const std::string &message) {
+  if (public_key.size() != crypto_sign_PUBLICKEYBYTES || signature.size() != crypto_sign_BYTES) {
+    return false;
+  }
   return crypto_sign_verify_detached(reinterpret_cast<const unsigned char *>(signature.c_str()),
                                      reinterpret_cast<const unsigned char *>(message.c_str()), message.size(),
                                      reinterpret_cast<const unsigned char *>(public_key.c_str())) == 0;

Would also be good to unit test this case in libaktualizr/crypto/crypto_test.cc

[lbonn]

Great, we can merge it after fixing the formatting error.

[lbonn]

There are now some merge conflicts, it would need a last rebase before merging.