Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Remove the fallback on clang-{tidy,format} #1240

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

lbonn
Copy link
Contributor

@lbonn lbonn commented Jun 21, 2019

This creates more problems than it solves.

We've talked about it, here it is.

We can also think about switching to newer versions later, but it would probably need some effort to make the lint happy.

This creates more problems than it solves

Signed-off-by: Laurent Bonnans <laurent.bonnans@here.com>
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's time and this seems like the right thing to do for now.

@codecov-io
Copy link

Codecov Report

Merging #1240 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
+ Coverage   79.31%   79.47%   +0.15%     
==========================================
  Files         170      170              
  Lines       10123    10123              
==========================================
+ Hits         8029     8045      +16     
+ Misses       2094     2078      -16
Impacted Files Coverage Δ
src/libaktualizr/storage/sqlstorage_base.cc 76.35% <0%> (-2.03%) ⬇️
src/libaktualizr/storage/sqlstorage.cc 76.57% <0%> (+0.51%) ⬆️
src/libaktualizr/uptane/imagesrepository.cc 93.2% <0%> (+0.61%) ⬆️
src/libaktualizr/primary/sotauptaneclient.cc 93.07% <0%> (+0.75%) ⬆️
src/aktualizr_primary/secondary.cc 87.67% <0%> (+1.36%) ⬆️
src/libaktualizr/uptane/directorrepository.cc 97.14% <0%> (+1.42%) ⬆️
src/libaktualizr/package_manager/ostreemanager.cc 77.11% <0%> (+1.69%) ⬆️
src/libaktualizr-posix/ipuptanesecondary.cc 86.66% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a89dc1d...eab7b63. Read the comment docs.

@lbonn lbonn merged commit 8a2c09f into master Jun 21, 2019
@lbonn lbonn deleted the fix/mandate-clang-xx-versions branch June 21, 2019 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants