This repository has been archived by the owner on May 21, 2024. It is now read-only.
OTA-3716: Full file download If a byte range request fails #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattivacek
reviewed
Oct 16, 2019
mike-sul
force-pushed
the
fix/OTA-3716/fallback-for-failed-byte-range
branch
from
20e45da to
8131bed
Compare
Codecov Report
@@ Coverage Diff @@
## master #1416 +/- ##
==========================================
+ Coverage 80.38% 80.44% +0.05%
==========================================
Files 181 181
Lines 10637 10642 +5
==========================================
+ Hits 8551 8561 +10
+ Misses 2086 2081 -5
Continue to review full report at Codecov.
|
lbonn
reviewed
Oct 16, 2019
… not supported by a server Signed-off-by: Mykhaylo Sul <myk.sul@gmail.com>
mike-sul
force-pushed
the
fix/OTA-3716/fallback-for-failed-byte-range
branch
from
8131bed to
dc94edd
Compare
lbonn
approved these changes
Oct 16, 2019
|
can it be merged ? |
|
Sure :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to a full file download if a byte range request fails (a server does not support it).
Ideally, this logic should be "behind" HttpInterface interface and encapsulated in HttpClient implementation of this interface. Unfortunately, there is an additional user context for the download process that is owned by a client (DownloadMetaStruct in packagemanagerinterface.cc) which has to be managed/reset in case of download retry and which is opaque within HttpClient.
Signed-off-by: Mykhaylo Sul myk.sul@gmail.com