This repository has been archived by the owner on May 21, 2024. It is now read-only.
Fix/ostree logging #1466
Merged
Fix/ostree logging #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By calling getCurrent() in finalizeInstall(), an error was printed that the stored and deployed hashes did not match. That is expected in that case. Besides, there was no reason to check the stored hash at that time at all, so I've refactored the code to only get the hash at that time and thus only check what we really care about. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
Do not be thrown off as I was about Secondaries being able to use getCurrent() due to calling functions with the word "Primary" in the name. They will work fine on Secondaries since Secondaries only know about themselves. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
pattivacek
requested review from
lbonn,
eu-siemann,
mike-sul,
Zee314159,
xcheng-here and
kbushgit
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
==========================================
- Coverage 80.61% 80.57% -0.04%
==========================================
Files 184 184
Lines 11079 11081 +2
==========================================
- Hits 8931 8929 -2
- Misses 2148 2152 +4
Continue to review full report at Codecov.
|
lbonn
approved these changes
Dec 2, 2019
eu-siemann
approved these changes
Dec 2, 2019
mike-sul
approved these changes
Dec 2, 2019
Good point. I was mostly just being lazy but if we come through here again we can do better. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.